Skip to content

Seencheck improvements#522

Merged
NGTmeaty merged 4 commits intomainfrom
seencheck-retry
Dec 10, 2025
Merged

Seencheck improvements#522
NGTmeaty merged 4 commits intomainfrom
seencheck-retry

Conversation

@NGTmeaty
Copy link
Copy Markdown
Collaborator

This should stop the panics from Seencheck failures as well as add retries. We do have additional work to do in #521 .

@NGTmeaty NGTmeaty requested a review from willmhowes November 19, 2025 03:09
@NGTmeaty NGTmeaty self-assigned this Nov 19, 2025
@NGTmeaty NGTmeaty added the bug Something isn't working label Nov 19, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 19, 2025

Codecov Report

❌ Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.43%. Comparing base (73c7dde) to head (7ab7df9).
⚠️ Report is 41 commits behind head on main.

Files with missing lines Patch % Lines
internal/pkg/source/hq/hq.go 0.00% 3 Missing ⚠️
internal/pkg/controler/pipeline.go 0.00% 1 Missing ⚠️
internal/pkg/preprocessor/preprocessor.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #522      +/-   ##
==========================================
+ Coverage   56.37%   56.43%   +0.06%     
==========================================
  Files         131      131              
  Lines        6570     6577       +7     
==========================================
+ Hits         3704     3712       +8     
+ Misses       2491     2490       -1     
  Partials      375      375              
Flag Coverage Δ
e2etests 42.01% <54.54%> (+0.07%) ⬆️
unittests 28.77% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread internal/pkg/preprocessor/preprocessor.go Outdated
Return the error instead of setting seed status to failed.
Copy link
Copy Markdown
Collaborator

@willmhowes willmhowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@NGTmeaty NGTmeaty merged commit 73cf7ad into main Dec 10, 2025
5 checks passed
@NGTmeaty NGTmeaty deleted the seencheck-retry branch December 10, 2025 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants