Skip to content

fix: connection is nil#545

Merged
NGTmeaty merged 1 commit intomainfrom
fix/missing-conn
Jan 20, 2026
Merged

fix: connection is nil#545
NGTmeaty merged 1 commit intomainfrom
fix/missing-conn

Conversation

@yzqzss
Copy link
Copy Markdown
Collaborator

@yzqzss yzqzss commented Jan 18, 2026

This bug was introduced in #356.

I guess that when I refactored two archiver.go files to achieve headless functionality, I somehow copied and pasted the resp.Body code from headless/archiver directly into general/archiver.

I'm not sure about the actual impact of this issue; could it lead to leaked connections?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 18, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 56.67%. Comparing base (a502d49) to head (decfeaa).
⚠️ Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
internal/pkg/archiver/general/body.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #545      +/-   ##
==========================================
+ Coverage   56.56%   56.67%   +0.10%     
==========================================
  Files         131      131              
  Lines        6606     6606              
==========================================
+ Hits         3737     3744       +7     
+ Misses       2494     2487       -7     
  Partials      375      375              
Flag Coverage Δ
e2etests 42.23% <66.66%> (+0.10%) ⬆️
unittests 28.92% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yzqzss yzqzss requested a review from NGTmeaty January 18, 2026 21:30
Copy link
Copy Markdown
Collaborator

@NGTmeaty NGTmeaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'm not certain either but definitely a good catch!

@NGTmeaty NGTmeaty merged commit e18fd5d into main Jan 20, 2026
5 checks passed
@NGTmeaty NGTmeaty deleted the fix/missing-conn branch January 20, 2026 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants