Skip to content

feat: update gowarc#554

Merged
NGTmeaty merged 3 commits intomainfrom
gowarc-update-feb-3-26
Feb 4, 2026
Merged

feat: update gowarc#554
NGTmeaty merged 3 commits intomainfrom
gowarc-update-feb-3-26

Conversation

@NGTmeaty
Copy link
Copy Markdown
Collaborator

@NGTmeaty NGTmeaty commented Feb 3, 2026

No description provided.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.56%. Comparing base (aa1fbdb) to head (7a7cc0d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #554      +/-   ##
==========================================
- Coverage   56.61%   56.56%   -0.06%     
==========================================
  Files         131      131              
  Lines        6620     6621       +1     
==========================================
- Hits         3748     3745       -3     
- Misses       2498     2502       +4     
  Partials      374      374              
Flag Coverage Δ
e2etests 42.12% <100.00%> (-0.06%) ⬇️
unittests 28.86% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

willmhowes
willmhowes previously approved these changes Feb 4, 2026
Copy link
Copy Markdown
Collaborator

@willmhowes willmhowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiled and ran a test crawl locally, lgtm!

Comment thread internal/pkg/archiver/warc.go Outdated
Copy link
Copy Markdown
Collaborator

@willmhowes willmhowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after your fix!

@NGTmeaty NGTmeaty merged commit 8d29277 into main Feb 4, 2026
5 checks passed
@NGTmeaty NGTmeaty deleted the gowarc-update-feb-3-26 branch February 4, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants