Skip to content

workaround: add recover to prevent panic in PDF outlink extractor#565

Merged
NGTmeaty merged 1 commit intomainfrom
workaround/pdfcpu-panic
Feb 26, 2026
Merged

workaround: add recover to prevent panic in PDF outlink extractor#565
NGTmeaty merged 1 commit intomainfrom
workaround/pdfcpu-panic

Conversation

@yzqzss
Copy link
Copy Markdown
Collaborator

@yzqzss yzqzss commented Feb 26, 2026

Just a workaround, as pdfcpu hasn't released a new version in a long time.

@yzqzss yzqzss added the bug Something isn't working label Feb 26, 2026
@yzqzss yzqzss closed this Feb 26, 2026
@NGTmeaty NGTmeaty merged commit 187dd18 into main Feb 26, 2026
5 checks passed
@yzqzss
Copy link
Copy Markdown
Collaborator Author

yzqzss commented Feb 26, 2026

ohh, NOOO, I missed. They actually released a new version.

v0.11.1

@yzqzss
Copy link
Copy Markdown
Collaborator Author

yzqzss commented Feb 26, 2026

let's revert the commit and upgrade to pdfcpu v0.11.1

@NGTmeaty
Copy link
Copy Markdown
Collaborator

ooooops. Will resolve 😅 no worries

yzqzss added a commit that referenced this pull request Feb 26, 2026
NGTmeaty pushed a commit that referenced this pull request Feb 26, 2026
@NGTmeaty NGTmeaty deleted the workaround/pdfcpu-panic branch February 26, 2026 23:24
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.37%. Comparing base (d475a60) to head (dd5f432).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
internal/pkg/postprocessor/extractor/pdf.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #565      +/-   ##
==========================================
- Coverage   56.44%   56.37%   -0.07%     
==========================================
  Files         132      132              
  Lines        6718     6721       +3     
==========================================
- Hits         3792     3789       -3     
- Misses       2549     2554       +5     
- Partials      377      378       +1     
Flag Coverage Δ
e2etests 41.88% <0.00%> (-0.08%) ⬇️
unittests 29.01% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants