Skip to content

WEBDEV-8503 Migrate ia-button to elements#56

Merged
rebecca-shoptaw merged 16 commits into
mainfrom
webdev-8503-migrate-ia-button-to-elements
Jun 2, 2026
Merged

WEBDEV-8503 Migrate ia-button to elements#56
rebecca-shoptaw merged 16 commits into
mainfrom
webdev-8503-migrate-ia-button-to-elements

Conversation

@rebecca-shoptaw
Copy link
Copy Markdown
Collaborator

Moves the ia-button component from Offshoot into Elements. It's mostly a simple copy-paste, with the only big difference being switching from using parent-applied classes for styling, to using a property called mode, i.e. <ia-button class="primary"> -> <ia-button mode="primary">

Also renames the CSS variables to match our new conventions and creates a set of theme variables where needed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 29, 2026

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-06-02 19:05 UTC

Comment thread src/elements/ia-button/ia-button.test.ts
Comment thread src/elements/ia-button/ia-button.ts
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 29, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.45%. Comparing base (6661c83) to head (1cddcd1).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/elements/ia-button/ia-button.ts 50.00% 12 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
- Coverage   79.66%   78.45%   -1.21%     
==========================================
  Files          16       16              
  Lines         659      687      +28     
  Branches      177      186       +9     
==========================================
+ Hits          525      539      +14     
- Misses         90      102      +12     
- Partials       44       46       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@latonv latonv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice migration! Spotted one possible typo.

Comment thread src/elements/ia-button/ia-button-story.ts
Comment thread src/elements/ia-button/ia-button-story.ts Outdated
Comment thread src/elements/ia-button/ia-button.ts Outdated
@rebecca-shoptaw rebecca-shoptaw force-pushed the webdev-8503-migrate-ia-button-to-elements branch from 5d5b562 to d8bb9fd Compare June 1, 2026 18:17
@rebecca-shoptaw rebecca-shoptaw merged commit 5d93835 into main Jun 2, 2026
3 checks passed
@rebecca-shoptaw rebecca-shoptaw deleted the webdev-8503-migrate-ia-button-to-elements branch June 2, 2026 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants