WEBDEV-8503 Migrate ia-button to elements#56
Merged
Conversation
|
rebecca-shoptaw
commented
May 29, 2026
rebecca-shoptaw
commented
May 29, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56 +/- ##
==========================================
- Coverage 79.66% 78.45% -1.21%
==========================================
Files 16 16
Lines 659 687 +28
Branches 177 186 +9
==========================================
+ Hits 525 539 +14
- Misses 90 102 +12
- Partials 44 46 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
latonv
approved these changes
May 30, 2026
Member
latonv
left a comment
There was a problem hiding this comment.
LGTM, nice migration! Spotted one possible typo.
latonv
reviewed
May 30, 2026
5d5b562 to
d8bb9fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the
ia-buttoncomponent from Offshoot into Elements. It's mostly a simple copy-paste, with the only big difference being switching from using parent-applied classes for styling, to using a property calledmode, i.e.<ia-button class="primary">-><ia-button mode="primary">Also renames the CSS variables to match our new conventions and creates a set of theme variables where needed.