Update README and add LICENSE.txt#256
Merged
ato merged 1 commit intointernetarchive:masterfrom Aug 5, 2019
ruebot:readme-updates
Merged
Update README and add LICENSE.txt#256ato merged 1 commit intointernetarchive:masterfrom ruebot:readme-updates
ato merged 1 commit intointernetarchive:masterfrom
ruebot:readme-updates
Conversation
ruebot
commented
Apr 22, 2019
| Heritrix is distributed with the libraries it depends upon. The | ||
| libraries can be found under the 'lib' directory, and are used under | ||
| the terms of their respective licenses, which are included alongside | ||
| the libraries in the 'lib' directory. |
Collaborator
Author
There was a problem hiding this comment.
I removed this lib directory bit, since there doesn't appear to be one. $ find . -iname "lib" -type d came up with nothing. 🤷♂️
Collaborator
There was a problem hiding this comment.
It's referring to the release distribution:
$ unzip -l heritrix-3.4.0-20190418-dist.zip
...
672169 04-18-2019 15:38 heritrix-3.4.0-20190418/lib/heritrix-engine-3.4.0-20190418.jar
408013 04-18-2019 15:38 heritrix-3.4.0-20190418/lib/heritrix-modules-3.4.0-20190418.jar
157363 04-18-2019 15:38 heritrix-3.4.0-20190418/lib/heritrix-commons-3.4.0-20190418.jar
592008 12-14-2014 13:10 heritrix-3.4.0-20190418/lib/httpclient-4.3.6.jar
282793 12-14-2014 13:10 heritrix-3.4.0-20190418/lib/httpcore-4.3.3.jar
...
1407 04-18-2019 15:38 heritrix-3.4.0-20190418/lib/bsh.LICENSE
11558 04-18-2019 15:38 heritrix-3.4.0-20190418/lib/jetty.LICENSE
1404 04-18-2019 15:38 heritrix-3.4.0-20190418/lib/poi.NOTICE
Collaborator
Author
|
The other thought I had updating this was adding a |
- Add badges to README - Update Markdown - Clean-up formatting - Add LICENSE.txt in root - Partially addresses #233
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The javadocs badge displays the current release number, but links to the
3.2.0docs. Looking at the release procedures, it doesn't look like they get updated. Should we create a separate issue to take care of this?