HER-1998

[adam-miller]

HER-1998 - ExtractorHTML modified to parse html inside conditional comments. Still ignores normal comments

[nlevitt]

Thanks Adam! Could you add a comment in there briefly explaining the
"<!--[if IE 6]>" thing and linking to more info online or something
like that?

On Fri, Mar 16, 2012 at 14:39, Adam Miller
reply@reply.github.com
wrote:

HER-1998 - ExtractorHTML modified to parse html inside conditional comments. Still ignores normal comments

You can merge this Pull Request by running:

 git pull https://github.com/adam-miller/heritrix3 master

Or you can view, comment on it, or merge it online at:

 #5

-- Commit Summary --

• HER-1998 - ExtractorHTML modified to parse html inside conditional comments. Still ignores normal comments

-- File Changes --

M modules/src/main/java/org/archive/modules/extractor/ExtractorHTML.java (2)
M modules/src/test/java/org/archive/modules/extractor/ExtractorHTMLTest.java (28)

-- Patch Links --

 https://github.com/internetarchive/heritrix3/pull/5.patch
 https://github.com/internetarchive/heritrix3/pull/5.diff

---

Reply to this email directly or view it on GitHub:
#5

[adam-miller]

Expanded HER-1998 to explain more about conditional comments. Added the following:

Conditional comments are used by some versions of Internet Explorer to allow html specific to a browser version to be ignored by other browsers/versions

Typical HTML Comment:
""

Conditional HTML comment:
""

This technique is commonly used to reference CSS & JavaScript that are designed to deal with the quirks of a specific version of Internet Explorer.

There is another syntax for conditional comments which already gets parsed by the regex since it doesn't start with "<!--"
<!if expression> HTML <!endif>

https://en.wikipedia.org/wiki/Conditional_Comments

[nlevitt]

Adam thanks... I meant it should go in the code though... so if you
could paste it in there then you can go ahead and push to
origin/master yourself

On Mon, Mar 19, 2012 at 12:13, Adam Miller
reply@reply.github.com
wrote:

Expanded HER-1998 to explain more about conditional comments. Added the following:

Conditional comments are used by some versions of Internet Explorer to allow html specific to a browser version to be ignored by other browsers/versions

Typical HTML Comment:

Conditional HTML comment:

This technique is commonly used to reference CSS & JavaScript that are designed to deal with the quirks of a specific version of Internet Explorer.

There is another syntax for conditional comments which already gets parsed by the regex since it doesn't start with "<!--"
<!if expression> HTML <!endif>

https://en.wikipedia.org/wiki/Conditional_Comments

---

Reply to this email directly or view it on GitHub:
#5 (comment)