Skip to content

HER-2001: Use the CodeMirror editor for crawl config and script console#6

Merged
gojomo merged 1 commit intointernetarchive:masterfrom
ato:codemirror
Apr 25, 2012
Merged

HER-2001: Use the CodeMirror editor for crawl config and script console#6
gojomo merged 1 commit intointernetarchive:masterfrom
ato:codemirror

Conversation

@ato
Copy link
Copy Markdown
Collaborator

@ato ato commented Mar 31, 2012

This enables syntax-highlighting, line-numbering and auto-indent for the crawl
configuration editor and the script console (for BeanShell, JavaScript and
Groovy).

Screenshots attached to the JIRA issue: https://webarchive.jira.com/browse/HER-2001

Please let me know if you prefer to receive patches some other way.

  • BaseResource.java
    add a more generic getStaticRef() in addition to getStylesheetRef()
  • EditRepresentation.java
    wrap textarea with CodeMirror in purexml mode.
    disable the "save changes" button until config is edited.
    dynamically resize CodeMirror edit element to fit window height.
  • ScriptResource.java
    wrap textarea with CodeMirror.
    switch CodeMirror language modes depending on selected script engine.
  • resources/.../restlet/codemirror/
    include just the files from codemirror-2.23.zip necessary for the above
    plus the CodeMirror LICENSE file (MIT)
    plus a README linking to the codemirror website

This enables syntax-highlighting, line-numbering and auto-indent for the crawl
configuration editor and the script console (for BeanShell, JavaScript and
Groovy).

* BaseResource.java
    add a more generic getStaticRef() in addition to getStylesheetRef()
* EditRepresentation.java
    wrap textarea with CodeMirror in purexml mode.
    disable the "save changes" button until config is edited.
    dynamically resize CodeMirror edit element to fit window height.
* ScriptResource.java
    wrap textarea with CodeMirror.
    switch CodeMirror language modes depending on selected script engine.
* resources/.../restlet/codemirror/
    include just the files from codemirror-2.23.zip necessary for the above
    plus the CodeMirror LICENSE file (MIT)
    plus a README linking to the codemirror website
gojomo added a commit that referenced this pull request Apr 25, 2012
HER-2001: Use the CodeMirror editor for crawl config and script console
    (Thanks Alex!)
@gojomo gojomo merged commit e4f12bb into internetarchive:master Apr 25, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants