FIX corner-case of bean browser failing due to an exception from hashCode()#95
Merged
nlevitt merged 1 commit intointernetarchive:masterfrom Oct 4, 2014
Merged
Conversation
nlevitt
added a commit
that referenced
this pull request
Oct 4, 2014
FIX corner-case of bean browser failing due to an exception from hashCode()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know this is a corner-case, but when a bean exposes an object as a property whose
hashCode()method can fail, it kills entire bean browser. For example, with an ArrayList being changed at high frequency, itshashCode()can throwConcurrentModificationExcpetion.Doing object-identity based test for
alreadyWrittenwill fix it, but I don't know the good way to implement it (there'sSystem.identityHashCode(Object), but there's no real guarantee for uniqueness). For now, this patch simply catches exceptions fromhashCode()and assumes it's never seen before.