WEBDEV-7818 Decouple results header from smart results & use named slot instead #507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #507 +/- ##
==========================================
- Coverage 92.66% 92.65% -0.01%
==========================================
Files 112 112
Lines 18844 18840 -4
Branches 1474 1470 -4
==========================================
- Hits 17461 17457 -4
Misses 1312 1312
Partials 71 71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jbuckner
reviewed
Nov 6, 2025
jbuckner
approved these changes
Nov 10, 2025
latonv
force-pushed
the
webdev7818-search-beta-header-slots
branch
from
8735480 to
928ea59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the option to specify a custom heading atop the results is gated by the
showSmartResultsproperty. However, we would like to be able to customize this heading independent of whether the smart results layout is being used.This PR instead exposes a
results-headingnamed slot regardless of theshowSmartResultsflag, to replace the oldresultsHeaderproperty.Two CSS vars related to spacing around the header and upper facet area are also exposed to allow customizing & aligning the header as needed.