Skip to content

WEBDEV-7351 Make PR deploy links point directly to /demo/ #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2025
Merged

WEBDEV-7351 Make PR deploy links point directly to /demo/ #86

merged 1 commit into from
Mar 7, 2025

Conversation

@rebecca-shoptaw
Copy link
Contributor

@rebecca-shoptaw rebecca-shoptaw commented Mar 5, 2025 •
edited
Loading

Uses a custom sticky comment configuration so that new deployments will link directly to the app rendered at /demo/ instead of 404-ing.

@github-actions
Copy link

github-actions bot commented Mar 5, 2025 •
edited
Loading

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-03-07 14:37 UTC

@codecov
Copy link

codecov bot commented Mar 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3165ddb) to head (e4712f6).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main       #86   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           29        29           
=========================================
  Hits            29        29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rebecca-shoptaw rebecca-shoptaw marked this pull request as draft March 5, 2025 21:19
@rebecca-shoptaw rebecca-shoptaw force-pushed the webdev-7351-fix-demo-deployment-issue branch 2 times, most recently from 3c06ada to 9fff54c Compare March 5, 2025 22:15
@rebecca-shoptaw rebecca-shoptaw force-pushed the webdev-7351-fix-demo-deployment-issue branch from 5baa5cf to e4712f6 Compare March 6, 2025 14:26
@rebecca-shoptaw rebecca-shoptaw marked this pull request as ready for review March 6, 2025 14:27
@rebecca-shoptaw rebecca-shoptaw changed the title WEBDEV-7351 Make PR deploy links point directly to /demo WEBDEV-7351 Make PR deploy links point directly to /demo/ Mar 6, 2025
@rebecca-shoptaw rebecca-shoptaw merged commit dab07c8 into main Mar 7, 2025
4 checks passed
@rebecca-shoptaw rebecca-shoptaw deleted the webdev-7351-fix-demo-deployment-issue branch March 7, 2025 14:36
jbuckner added a commit that referenced this pull request Mar 7, 2025
@jbuckner
Merge branch 'main' into webdev-7210-update-dependencies
bf597c4 
* main:
  Add /demo/ to commented deploy URL (#86)
  WEBDEV-7347 Update codecov configuration and docs (#84)
  Update README.md to include note on how we release npm packages (#82)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbuckner jbuckner jbuckner approved these changes

@dualcnhq dualcnhq dualcnhq approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rebecca-shoptaw @jbuckner @dualcnhq