Merged
Conversation
Use POST method to initialize Tara request. No further action should be required anymore.
Contributor
|
tara auth and user creation continues to work as expected. |
Contributor
Author
|
Additional comment here: We were not vulnerable to this exploit because Tara does not allow a user to be persistently logged in But, if we were to ever introduce Google's or Facebook's SSO, then we would be exposed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Protect against CVE-2015-9284
Use POST method to initialize Tara request. No further action should be required anymore.
Please ensure that Tara login and user creation continues to work after this.