Add sorting by highest price and number of offers#299
Merged
Conversation
maciej-szlosarczyk
force-pushed
the
add-sorting-by-highest-price-and-number-of-offers
branch
from
406c78b to
deb59a0
Compare
maciej-szlosarczyk
force-pushed
the
add-sorting-by-highest-price-and-number-of-offers
branch
from
4e2ced1 to
7c86bc9
Compare
maciej-szlosarczyk
force-pushed
the
add-sorting-by-highest-price-and-number-of-offers
branch
from
7c86bc9 to
e45fb51
Compare
added 12 commits
July 23, 2019 14:44
By default, Postgres displays null values first, which is not something a user wants to see in the user interface
Additionally, removes a nasty N+1 query from that page
maciej-szlosarczyk
force-pushed
the
add-sorting-by-highest-price-and-number-of-offers
branch
from
4e7bbc3 to
cd5fa8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In administrator UI, you can now sort auctions by highest offer and number of offers.A participant can also order auctions by a new parameter - his/her own biggest offer. Both also work in search.
Fxes #128, should improve overall performance.
Things to check while testing: