Merged
Conversation
artur-intech
approved these changes
Nov 15, 2019
Contributor
There was a problem hiding this comment.
Lock Sprockets to ~> 3.7. Sprockets 4.x has a new approach on how to deliver assets, but we mainly use Webpacker so there's no reason to migrate to new version.
It's worth putting this description into respective commit message. Otherwise it will be a mystery why is it locked just to that version when looking at Gemfile.
Sprockets 4.x has a new approach on how to deliver assets, but we mainly use Webpacker so there's no reason to migrate to new version.
karlerikounapuu
force-pushed
the
bump-gem-versions
branch
from
92b4250 to
c6be53c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second part of upgrading Ruby to 2.6.5