fix: update write controller to handle base64 encoded file paths#340
Merged
egalvis27 merged 1 commit intoMay 12, 2026
Merged
Conversation
|
AlexisMora
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is Changed / Added
Uploading files with non-ASCII names (for example Cyrillic characters or
ñ) caused path encoding issues in the FUSE -> backend write flow, producing mojibake paths in some cases.Additionally, filenames containing line breaks are not safe to transport in plain HTTP headers, which could break write requests and lead to downstream failures (including thumbnail generation in some scenarios).
Solution
This PR introduces a single, explicit contract for write-path transport:
X-Path-B64header.writecontroller decodesX-Path-B64and uses the decoded path for the write operation.X-Pathcompatibility/fallback logic was removed to keep the flow strict and simpler (safe to do because this is not in production yet).