fix: prevent duplicate uploads by skipping release when an upload is already in progress#347
Merged
Merged
Conversation
…already in progress
|
AlexisMora
approved these changes
May 25, 2026
Comment on lines
+146
to
+147
| resolveFirstUpload(); | ||
| await first; |
Author
There was a problem hiding this comment.
This line is intended to clear the set that stores uploads in progress, so they don't remain there and interfere with other tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is Changed / Added
When a file is written through the virtual drive, the FUSE daemon creates one
InternxtFilehandle perOpen()/Create()call.Release()is triggeredonce per handle — not once per file — so opening the same path twice (e.g. one
descriptor for the write and a second one opened by GNOME's
pool-org.gnome.*worker to read metadata) results in two independent
POST /op/releaserequestsfor the same path.
Both releases found the temporal file, found no existing remote file yet, and
raced to upload and then register the file metadata. The first one succeeded;
the second hit a
409 File already existsfrom the Drive server, which was thenpropagated as an unhandled error and logged twice.