Skip to content

Conversation

@jzunigax2
Copy link
Contributor

@jzunigax2 jzunigax2 commented Mar 31, 2025

Description

In the security section, when "exporting backup keys", we now export a json format that besides storing the plain mnemonic also stores each unencrypted private key. So that when the user attempts to recover these keys they will get encrypted with the new password and be updated on the backend.

For existing files the account recoery remains the same, meaning that if the json.parse fails we fallback to interpreting the file as the plain mnemonic

Related Issues

Related Pull Requests

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

How Has This Been Tested?

How Has This Been Tested

  1. Export Backup Key from Settings:

    • Navigate to the Preferences -> Security.
    • Export the backup key file saving it locally.
  2. Account Recovery Process:

    • Go to the login screen.
    • Click on the "Forgot Password" link.
    • Follow the prompts to recover the account using the exported backup key file.
    • Verify that the account recovery process completes successfully and that the account is accessible.
  3. Testing with Legacy Backup Files:

    • Obtain a legacy backup file or edit it to match the legacy format (only contains plain mnemonic text).
    • Repeat the account recovery process:
      • Go to the login screen.
      • Click on "Forgot Password."
      • Attempt to recover the account using the legacy backup file.
    • Confirm that the recovery process works as expected with the legacy backup file.

All these steps can only be tested with the changes being introduced in internxt/drive-server-wip/pull/506

Additional Notes

@jzunigax2 jzunigax2 added the enhancement New feature or request label Mar 31, 2025
@jzunigax2 jzunigax2 requested a review from apsantiso March 31, 2025 13:08
@jzunigax2 jzunigax2 self-assigned this Mar 31, 2025
@vercel
Copy link

vercel bot commented Mar 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Project Deployment Preview Comments Updated (UTC)
drive-web Ready Preview Comment Aug 13, 2025 8:53am

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 31, 2025

Deploying drive-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: 059e63a
Status: ✅  Deploy successful!
Preview URL: https://5b99b158.drive-web.pages.dev
Branch Preview URL: https://feat-recover-private-keys.drive-web.pages.dev

View logs

Copy link
Collaborator

@CandelR CandelR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to add the steps in the How Has This Been Tested section

Copy link
Collaborator

@CandelR CandelR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Waiting for drive-server-wip changes to pass to QA
Good job @jzunigax2 🚀

@CandelR CandelR changed the title feat: recover private keys when recovering account [PB-3703] feat: recover private keys when recovering account May 29, 2025
@CandelR
Copy link
Collaborator

CandelR commented May 29, 2025

Hey @jzunigax2, remember to update this branch with master in order to let it ready for QA and release it

@jzunigax2 jzunigax2 removed the request for review from a team July 28, 2025 22:14
@sonarqubecloud
Copy link

@CandelR CandelR merged commit 6306fcb into master Aug 13, 2025
15 of 16 checks passed
@CandelR CandelR deleted the feat/recover-private-keys branch August 13, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request ready-for-preview

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants