-
Notifications
You must be signed in to change notification settings - Fork 32
[PB-3703] feat: recover private keys when recovering account #1508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Deploying drive-web with
|
| Latest commit: |
059e63a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5b99b158.drive-web.pages.dev |
| Branch Preview URL: | https://feat-recover-private-keys.drive-web.pages.dev |
CandelR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember to add the steps in the How Has This Been Tested section
…eat/recover-private-keys
CandelR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! Waiting for drive-server-wip changes to pass to QA
Good job @jzunigax2 🚀
|
Hey @jzunigax2, remember to update this branch with master in order to let it ready for QA and release it |
…-account-new-flow
…eat/recover-private-keys
…in legacy backup payload
|



Description
In the security section, when "exporting backup keys", we now export a json format that besides storing the plain mnemonic also stores each unencrypted private key. So that when the user attempts to recover these keys they will get encrypted with the new password and be updated on the backend.
For existing files the account recoery remains the same, meaning that if the json.parse fails we fallback to interpreting the file as the plain mnemonic
Related Issues
Related Pull Requests
Checklist
How Has This Been Tested?
How Has This Been Tested
Export Backup Key from Settings:
Account Recovery Process:
Testing with Legacy Backup Files:
All these steps can only be tested with the changes being introduced in internxt/drive-server-wip/pull/506
Additional Notes