Skip to content

v1.0.805

Choose a tag to compare

View all tags
@inxtci inxtci released this 01 Jul 11:04
v1.0.805
881c898
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode.

Description

Add bucketKey option to download to support the new sharing version (downloading of folders shared with the public sharing version "inxt-v3").

Changes:

  • add downloadOwnFileWithBucketKey function and refactor params to fit the old model
  • use NetworkCredentials from the same file instead of redefining it in multiple files
  • change mnemonic to FileKey = {mnemonic or bucketKey}
  • refactor NetworkFacade to reduce code repetitions

NOTE: The majority of deletes are coming from the download test, which was defining the same input in each test instead of declaring it once.

Related Issues

Relates to PB-6503

Related Pull Requests

Changes taken from this PR but based on the master branch.
Changes are for the new sharings.

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

Testing Process

Testing should ensure that the current download is not broken:

  • Downloading files and folders from the drive works.
  • Downloading publicly shared files and folders works.
  • Downloading publicly shared protected by password files and folders works.
  • Downloading of privately shared files and folders works.
  • Downloading of backups works.
  • Viewing middle fragments of big videos works (video streaming).

NOTE: Files and folders should be tested separately as they trigger different code paths.

Additional Notes

It was easier to check out changes to a new branch than to rebase.

Assets 2
Loading