Skip to content

v1.0.809

Choose a tag to compare

@inxtci inxtci released this 02 Jul 11:23
1498ca0

Description

The idea is always to use LocalStorageService to interact with local storage. This way, we can see the full list of items that we store and encrypt those that are sensitive.

This PR changes the remaining direct calls to local storage to LocalStorageService.

Related Issues

Relates to PB-6505

Related Pull Requests

Remove mnemonic
Remove old token

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

Testing Process

Check that banners are shown as before

Additional Notes

@xabg2 @jaaaaavier some keys were removed but never set. Are they set somewhere else, or can we remove them? Specifically those:

  • BunnerName = 'show_banner',
  • CustomerId = 'customerId',
  • CustomerToken = 'customerToken',
  • MobileToken = 'mobileToken',

I need to know if tokens are set somewhere else or not, as those values are secret and should not be in clear