Cleanup

[dajimenezriv-internxt]

What

Do a big cleanup of code that was no longer used. First, we need to find all code that is still used, for that I search org:internxt from '@internxt/inxt-js in github. After that I found the following repos using it:

• drive-desktop
• drive-desktop-linux
• cli
• drive-server-wip
• pc-cloud-old
• drive-desktop-test
• photos-server
• pc-cloud
• drive-server-old

For the relevant ones I search what imports are using from inxt-js:

// repo:internxt/drive-desktop-linux from '@internxt/inxt-js
import { Environment } from '@internxt/inxt-js';
import { GenerateFileKey } from '@internxt/inxt-js/build/lib/utils/crypto';
import { UploadStrategyFunction } from '@internxt/inxt-js/build/lib/core';
import { ActionState } from '@internxt/inxt-js/build/api';
import { DownloadOneShardStrategy } from '@internxt/inxt-js/build/lib/core';
import { DownloadStrategyFunction } from '@internxt/inxt-js/build/lib/core/download/strategy';

// repo:internxt/cli from '@internxt/inxt-js
import { Environment } from '@internxt/inxt-js';
// this is not used in `inxt-js` so it can be removed from the cli (however I haven't deleted it yet)
import { EncryptProgressCallback } from '@internxt/inxt-js/build/lib/core';

// repo:internxt/drive-desktop from '@internxt/inxt-js
import { Environment } from '@internxt/inxt-js';
import { ActionState } from '@internxt/inxt-js/build/api';

// repo:internxt/drive-server-wip from '@internxt/inxt-js
import { Environment } from '@internxt/inxt-js';

So, everything that is not used in one of those 4 repos will be removed.

The only thing that I assumed is no longer in use (since it's a command from 4 years ago) it's the cli command: https://github.com/internxt/inxt-js/pull/127/changes#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L18. So I deleted everything inside the cli folder.

The other part that is a bit tricky is the functions inside the Environment, so for that I used:

repo:internxt/drive-desktop-linux OR repo:internxt/cli OR repo:internxt/drive-desktop OR repo:internxt/drive-server-wip WHATEVER

I've also added knip to track better which functions, constants and so were used in the code and created a github pipeline to check that.

[dajimenezriv-internxt]

Never used: https://github.com/search?q=repo%3Ainternxt%2Fdrive-desktop-linux+OR+repo%3Ainternxt%2Fcli+OR+repo%3Ainternxt%2Fdrive-desktop+OR+repo%3Ainternxt%2Fdrive-server-wip+createBucket&type=code

[dajimenezriv-internxt]

Never used: https://github.com/search?q=repo%3Ainternxt%2Fdrive-desktop-linux+OR+repo%3Ainternxt%2Fcli+OR+repo%3Ainternxt%2Fdrive-desktop+OR+repo%3Ainternxt%2Fdrive-server-wip+deleteBucket&type=code

[dajimenezriv-internxt]

Never used: https://github.com/search?q=repo%3Ainternxt%2Fdrive-desktop-linux+OR+repo%3Ainternxt%2Fcli+OR+repo%3Ainternxt%2Fdrive-desktop+OR+repo%3Ainternxt%2Fdrive-server-wip+setEncryptionKey&type=code

[dajimenezriv-internxt]

https://github.com/search?q=repo%3Ainternxt%2Fdrive-desktop-linux+OR+repo%3Ainternxt%2Fcli+OR+repo%3Ainternxt%2Fdrive-desktop+OR+repo%3Ainternxt%2Fdrive-server-wip+uploadCancel&type=code

[dajimenezriv-internxt]

Never used: https://github.com/search?q=repo%3Ainternxt%2Fdrive-desktop-linux+OR+repo%3Ainternxt%2Fcli+OR+repo%3Ainternxt%2Fdrive-desktop+OR+repo%3Ainternxt%2Fdrive-server-wip+renameFile&type=code

[sg-gs]

So I deleted everything inside the cli folder.

@dajimenezriv-internxt The CLI is for using it locally, as this project does not have a HTTP server to try it, thus, it is not used outside this project

[dajimenezriv-internxt]

My question is if someone is still using the cli (I didn't even know it existed) so it's worth to mantain? Because for example, right now the upload and uploadMultipart are broken when I changed the upload from callbacks to promises. Not because I wanted to break it, but since it wasn't included in the tsconfig.json I didn't know it was broken until now. So, should we mantain it? In my case, when I have to test something from the environment I call it from windows. However, if we want to allow it from inxt-js, maybe it's easier to just declare a cli.ts file that has commented the code to creating an environment and you just call the function you want to test and it's simpler to mantain.

[dajimenezriv-internxt]

Another thing, we can keep the cli and the other commands in the environment and I can include them in the tsconfig.json and create another tsconfig.build.json, so at least we know if something it's broken, because I was checking other tests that are called *.unit.ts and some of them are also broken. With that we don't lose any feature that we already had and we start knowing if somethings gets broken.