Fix tsconfig target#134
Merged
Merged
Conversation
AlexisMora
approved these changes
May 14, 2026
sg-gs
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
There was an issue in the current version when uploading multipart files. This happened because an issue @AlexisMora found in the
asynclibrary about accepting a callback or not. The problem happened because in this PR thetsconfig targetwas changed: https://github.com/internxt/inxt-js/pull/129/changes#diff-b55cdbef4907b7045f32cc5360d48d262cca5f94062e353089f189f4460039e0R3, but in the tests it was still running with old one. So the tests were passing but the multipart upload of the build was broken.Now, we have removed the callback and the old target in the tests. Now, the tests run and the multipart upload works in the built version. So, the version
3.1.1is currently broken. @larryrider @AlexisMoraI've also deleted some code that was not used anywhere (it came from a private function with 0 references).