[_]: refactor/remove salt from mail address keys#32
Merged
jzunigax2 merged 2 commits intoApr 30, 2026
Conversation
xabg2
approved these changes
Apr 30, 2026
apsantiso
approved these changes
Apr 30, 2026
…pdates - Added getAddressKeys method to AccountService for retrieving encryption keys associated with a user's email address. - Introduced MailNotSetupException to handle cases where the mail account is not set up. - Updated UserController to include a new endpoint for fetching mail account keys. - Created GetMailAccountKeysDto for validating input on the new endpoint. - Enhanced unit tests for AccountService and UserController to cover new functionality and exception handling.
- Removed the 'salt' property from MailAddressKeys model, related DTOs, and service interfaces. - Updated migration to drop the 'salt' column from the mail_address_keys table. - Adjusted unit tests and fixtures to reflect the removal of the 'salt' attribute.
jzunigax2
force-pushed
the
refactor/remove-salt-references-from-stored-keys
branch
from
e067970 to
5abae85
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After this change in internxt-crypto internxt/crypto#56 keys are no longer derived from a user's password so salt was dropped as well.