Skip to content

[PB-5897] use session storage for anonymous ID#226

Merged
TamaraFinogina merged 1 commit intofix_reload_countfrom
use_session_storage
May 8, 2026
Merged

[PB-5897] use session storage for anonymous ID#226
TamaraFinogina merged 1 commit intofix_reload_countfrom
use_session_storage

Conversation

@TamaraFinogina
Copy link
Copy Markdown

Description

Anonymous ID is stored in sessionStorage instead of localStorage. This way, if a user joins from a new private window (incognito mode), a new anonymous ID is assigned. If the user reloads the tab, the anonymous ID is still the same, but for a new private window, it will be different.

Before, all private windows shared the same anonymous ID.

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

How Has This Been Tested?

QA in local

@TamaraFinogina TamaraFinogina self-assigned this May 7, 2026
@TamaraFinogina TamaraFinogina changed the title use session storage for anonymous ID [_] use session storage for anonymous ID May 7, 2026
@TamaraFinogina TamaraFinogina requested a review from CandelR May 7, 2026 16:22
@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
meet-web 3f25c18 Commit Preview URL

Branch Preview URL
May 07 2026, 04:24 PM

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 7, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
35.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

Deploying meet-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3f25c18
Status:  ✅  Deploy successful!
Preview URL: https://ba2b3b77.meet-web.pages.dev
Updated (Europe/Madrid): 7/5/2026, 18:25:59

View logs

@TamaraFinogina TamaraFinogina changed the title [_] use session storage for anonymous ID [PB-5897] use session storage for anonymous ID May 7, 2026
Comment on lines +27 to +29
public getAnonymousUUID(): string | null {
return sessionStorage.getItem(ANON_UUID_KEY);
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can use always getOrCreateAnonymousUUID and remove getAnonymousUUID, WDYT? Is there any situation where we wouldn't want to create it if it doesn't exist?

Copy link
Copy Markdown
Author

@TamaraFinogina TamaraFinogina May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, for leaving the call. If we try to leave the call and no token or anonymous ID is given, then the request will be just aborted by the server, else it will have to look in the DB

@TamaraFinogina TamaraFinogina merged commit fa8f52a into fix_reload_count May 8, 2026
7 of 8 checks passed
@TamaraFinogina TamaraFinogina deleted the use_session_storage branch May 8, 2026 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants