Create napi safe wrap#182
Merged
Merged
Conversation
| napi_create_int32(env, static_cast<int32_t>(result), &napiResult); | ||
| return napiResult; | ||
| napi_value RegisterSyncRootWrapper(napi_env env, napi_callback_info info) { | ||
| return napi_safe_wrap(env, info, register_sync_root_impl); |
Contributor
Author
There was a problem hiding this comment.
Here we are wrapping the register sync root function.
AlexisMora
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR creates a function
napi_safe_wrapthat is going to wrap all calls from javascript to C++. Why? If we throw an exception in C++ that is not handled successfully it breaks the javascript process. So, we create a wrapper that catches any exception and returns a valid javascript error.