Skip to content

internxt: enhance multipart upload handling with new upload cutoff an…#37

Merged
jzunigax2 merged 1 commit intomasterfrom
fix/multipart-address-code-review
Apr 16, 2026
Merged

internxt: enhance multipart upload handling with new upload cutoff an…#37
jzunigax2 merged 1 commit intomasterfrom
fix/multipart-address-code-review

Conversation

@jzunigax2
Copy link
Copy Markdown
Collaborator

@jzunigax2 jzunigax2 commented Apr 10, 2026

  • Replace hardcoded minMultipartSize with a configurable upload_cutoff option (min 100 MiB, max 5 GiB); adds SetUploadCutoff() for the UploadCutter interface
  • Use fs.FileTooSmallError instead of a plain error when a file is below the cutoff, so rclone's multipart framework falls back to single-part upload correctly
  • Switch pendingChunks from map[int][]byte to map[int]*pool.RW to use pooled buffers
  • Remove the MaxBufferMemory guard (now handled by the framework)
  • Implement DirCacheFlush() (dirCache.ResetRoot()) so the test framework can clear stale directory UUIDs between listing retries

@jzunigax2 jzunigax2 self-assigned this Apr 10, 2026
@jzunigax2 jzunigax2 force-pushed the fix/multipart-address-code-review branch from e3bf5b3 to 033fcdd Compare April 10, 2026 19:29
@jzunigax2 jzunigax2 requested a review from larryrider April 12, 2026 20:59
@jzunigax2 jzunigax2 added the enhancement New feature or request label Apr 12, 2026
@jzunigax2 jzunigax2 marked this pull request as ready for review April 12, 2026 20:59
@jzunigax2 jzunigax2 merged commit aab4bf2 into master Apr 16, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants