[PB-4903]: add stopMouseDownPropagation prop to Modal component #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and enhance tests
CandelR
reviewed
Oct 7, 2025
src/components/modal/Modal.tsx
Outdated
| <> | ||
| {showContent && ( | ||
| <div className="m-0"> | ||
| <div className="m-0" onMouseDown={(e) => stopMouseDownPropagation && e.stopPropagation()} role='modal'> |
Collaborator
There was a problem hiding this comment.
Consider extracting o avoid create new function on every render. Also change role='modal' to role="dialog" aria-modal="true" for ARIA compliance
Extract inline mouseDown handler to prevent function recreation on each render and update role attribute from 'modal' to 'dialog' with aria-modal for proper accessibility standards.
CandelR
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional stopMouseDownPropagation prop to control event propagation on mousedown events. Update role attribute to 'modal' for better accessibility and add corresponding tests.