Reduce number inferences in dice random#127
Merged
amit-sharma merged 3 commits intomasterfrom Apr 28, 2021
Merged
Conversation
Signed-off-by: gaugup <gaugup@microsoft.com>
Signed-off-by: gaugup <gaugup@microsoft.com>
gaugup
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like major time while computing counterfactuals in DiceRandom class is spent in calling get_output(). Hence, reducing the number of calls to get_couput() will reduce the run time. The PR does one call to get_output() for the query point and caches the result so that it can be reused across the computation of counterfactuals for that point. This optimizes the classification scenario only for now.