Enable flake8 linter in gates#131
Conversation
Signed-off-by: gaugup <gaugup@microsoft.com>
Signed-off-by: gaugup <gaugup@microsoft.com>
Signed-off-by: gaugup <gaugup@microsoft.com>
Signed-off-by: gaugup <gaugup@microsoft.com>
Signed-off-by: gaugup <gaugup@microsoft.com>
Signed-off-by: gaugup <gaugup@microsoft.com>
Signed-off-by: gaugup <gaugup@microsoft.com>
Signed-off-by: gaugup <gaugup@microsoft.com>
Signed-off-by: gaugup <gaugup@microsoft.com>
Signed-off-by: gaugup <gaugup@microsoft.com>
Signed-off-by: gaugup <gaugup@microsoft.com>
Signed-off-by: gaugup <gaugup@microsoft.com>
Signed-off-by: gaugup <gaugup@microsoft.com>
Signed-off-by: gaugup <gaugup@microsoft.com>
Signed-off-by: gaugup <gaugup@microsoft.com>
Signed-off-by: gaugup <gaugup@microsoft.com>
Signed-off-by: gaugup <gaugup@microsoft.com>
Signed-off-by: gaugup <gaugup@microsoft.com>
|
Thank you for fixing the flake8 tests @gaugup |
I will take a couple of more days to finish the remaining errors. I hope no PRs are merged in this time. |
Signed-off-by: gaugup <gaugup@microsoft.com>
…/dice_KD.py and explainer_interfaces/dice_genetic.py Signed-off-by: gaugup <gaugup@microsoft.com>
Signed-off-by: gaugup <gaugup@microsoft.com>
@amit-sharma, I created a milestone https://github.com/interpretml/DiCE/milestone/1 so that we can reduce the cyclometric complexity (https://www.geeksforgeeks.org/cyclomatic-complexity/) of certain methods within DiCE library. This can be done by refactoring certain code in these methods and the work for this milestone is outside the scope of this PR. For now I will set --max-complexity as 30 to avoid the cyclometric complexity to fail the flake8 gate. |
Signed-off-by: gaugup <gaugup@microsoft.com>
amit-sharma
left a comment
There was a problem hiding this comment.
thank you @gaugup for this massive effort! Will enable flake8 going forward for every PR.
Signed-off-by: gaugup gaugup@microsoft.com