Skip to content

Enable flake8 linter in gates#131

Merged
amit-sharma merged 23 commits intomasterfrom
gaugup/AddressPackageFlake8Errors
May 6, 2021
Merged

Enable flake8 linter in gates#131
amit-sharma merged 23 commits intomasterfrom
gaugup/AddressPackageFlake8Errors

Conversation

@gaugup
Copy link
Copy Markdown
Collaborator

@gaugup gaugup commented Apr 30, 2021

Signed-off-by: gaugup gaugup@microsoft.com

gaugup added 18 commits April 29, 2021 22:04
Signed-off-by: gaugup <gaugup@microsoft.com>
Signed-off-by: gaugup <gaugup@microsoft.com>
Signed-off-by: gaugup <gaugup@microsoft.com>
Signed-off-by: gaugup <gaugup@microsoft.com>
Signed-off-by: gaugup <gaugup@microsoft.com>
Signed-off-by: gaugup <gaugup@microsoft.com>
Signed-off-by: gaugup <gaugup@microsoft.com>
Signed-off-by: gaugup <gaugup@microsoft.com>
Signed-off-by: gaugup <gaugup@microsoft.com>
Signed-off-by: gaugup <gaugup@microsoft.com>
Signed-off-by: gaugup <gaugup@microsoft.com>
Signed-off-by: gaugup <gaugup@microsoft.com>
Signed-off-by: gaugup <gaugup@microsoft.com>
Signed-off-by: gaugup <gaugup@microsoft.com>
Signed-off-by: gaugup <gaugup@microsoft.com>
Signed-off-by: gaugup <gaugup@microsoft.com>
@amit-sharma
Copy link
Copy Markdown
Collaborator

Thank you for fixing the flake8 tests @gaugup
I still see some more errors in the flake8 run above, that we'll need to work on.

@gaugup
Copy link
Copy Markdown
Collaborator Author

gaugup commented May 3, 2021

Thank you for fixing the flake8 tests @gaugup
I still see some more errors in the flake8 run above, that we'll need to work on.

I will take a couple of more days to finish the remaining errors. I hope no PRs are merged in this time.

gaugup added 3 commits May 2, 2021 23:00
Signed-off-by: gaugup <gaugup@microsoft.com>
…/dice_KD.py and explainer_interfaces/dice_genetic.py

Signed-off-by: gaugup <gaugup@microsoft.com>
Signed-off-by: gaugup <gaugup@microsoft.com>
@gaugup
Copy link
Copy Markdown
Collaborator Author

gaugup commented May 3, 2021

Thank you for fixing the flake8 tests @gaugup
I still see some more errors in the flake8 run above, that we'll need to work on.

I will take a couple of more days to finish the remaining errors. I hope no PRs are merged in this time.

@amit-sharma, I created a milestone https://github.com/interpretml/DiCE/milestone/1 so that we can reduce the cyclometric complexity (https://www.geeksforgeeks.org/cyclomatic-complexity/) of certain methods within DiCE library. This can be done by refactoring certain code in these methods and the work for this milestone is outside the scope of this PR. For now I will set --max-complexity as 30 to avoid the cyclometric complexity to fail the flake8 gate.

@gaugup gaugup requested a review from amit-sharma May 3, 2021 19:35
Copy link
Copy Markdown
Collaborator

@amit-sharma amit-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @gaugup for this massive effort! Will enable flake8 going forward for every PR.

@amit-sharma amit-sharma merged commit 855ce7e into master May 6, 2021
@amit-sharma amit-sharma deleted the gaugup/AddressPackageFlake8Errors branch May 6, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants