Fix #182: Supporting private data for sklearn models #312
Merged
amit-sharma merged 24 commits intomasterfrom Oct 6, 2022
Merged
Fix #182: Supporting private data for sklearn models #312amit-sharma merged 24 commits intomasterfrom
amit-sharma merged 24 commits intomasterfrom
Conversation
Signed-off-by: Amit Sharma <amit_sharma@live.com>
…t/dice into amshar/method-compat-with-dl-models merging from github
Signed-off-by: Amit Sharma <amit_sharma@live.com>
Signed-off-by: Amit Sharma <amit_sharma@live.com>
Signed-off-by: Amit Sharma <amit_sharma@live.com>
Signed-off-by: Amit Sharma <amit_sharma@live.com>
Signed-off-by: Amit Sharma <amit_sharma@live.com>
Signed-off-by: Amit Sharma <amit_sharma@live.com>
Signed-off-by: Amit Sharma <amit_sharma@live.com>
Signed-off-by: Amit Sharma <amit_sharma@live.com>
Unit Test Results281 tests +20 276 ✔️ +20 11m 26s ⏱️ +4s Results for commit b3f7fe2. ± Comparison against base commit 1651751. This pull request removes 20 and adds 40 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Signed-off-by: Amit Sharma <amit_sharma@live.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #312 +/- ##
==========================================
+ Coverage 71.86% 71.99% +0.12%
==========================================
Files 26 26
Lines 3537 3596 +59
==========================================
+ Hits 2542 2589 +47
- Misses 995 1007 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
seakelle
reviewed
Jul 14, 2022
…dels Signed-off-by: Amit Sharma <amit_sharma@live.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[READY FOR MERGE]
This PR adds support for private data interface for sklearn ML models. dice-kdtree is not supported since it requires access to the training data to output the counterfactuals.