fix(notebook): remove trailing comma in DiCE_getting_started_feasible.ipynb JSON#467
Open
MukundaKatta wants to merge 1 commit intointerpretml:mainfrom
Open
Conversation
….ipynb JSON
The notebook's last two lines ('"nbformat_minor": 4,\n}\n') contained a
trailing comma, which makes the file invalid JSON. GitHub's notebook
preview and nbformat-based renderers refused to render it. Python's
json.load now succeeds after the fix.
Closes interpretml#439
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`docs/source/notebooks/DiCE_getting_started_feasible.ipynb` ended with an invalid trailing comma:
```
"nbformat": 4,
"nbformat_minor": 4,
}
```
Strict JSON doesn't allow that, so GitHub's notebook preview and nbformat-based tools refused to render the notebook. Removed the trailing comma after `"nbformat_minor": 4`. `json.load` now parses the file.
Closes #439
Testing
`python3 -c "import json; json.load(open('docs/source/notebooks/DiCE_getting_started_feasible.ipynb'))"` now succeeds.