Prevent users from accidentally opening multiple copies of the same class or routine #1666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isc-rsingh
approved these changes
Oct 31, 2025
gjsjohnmurray
approved these changes
Oct 31, 2025
Contributor
gjsjohnmurray
left a comment
gjsjohnmurray
left a comment
There was a problem hiding this comment.
Looks OK but I haven't tested it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue reported internally. A developer used
Cmd-Oto open a %Library class using the short alias. This opened a document with a different URI than if he opened it from the files explorer. This confused server-side source control and can confuse users if multiple copies are open at once. This PR fixes the issue by adding validation in ourFileSystemProviderto reject "non-canonical" URIs. I also modified theOpen InterSystems Document...command to be more flexible in what it accepts so opening a %Library class using its short alias is accepted and returns the "canonical" URI.