End the /terminalsocket session when window is closed or /logout command issued #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nikitaeverywhere
left a comment
nikitaeverywhere
left a comment
There was a problem hiding this comment.
Thanks for a valuable contribution. Indeed, there was such a problem.
| if (message.error '= "") { | ||
| if (message.error '[ "ERROR #7951") { // don't try and send message if it was a WS close error | ||
| set st = ..Send("error", message.error) | ||
| } |
Member
There was a problem hiding this comment.
It seems like there's a missing else statement. What happens if the error is not # 7591?
Contributor
Author
There was a problem hiding this comment.
I don't think the error message can be sent anywhere because the websocket has been closed. Line 197 will quit from the loop, and the new EndSession set will happen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents /terminalsocket sessions from remaining after user has closed the browser window or issued the /logout command.
Prior to this fix the sessions would linger for 15 minutes, consuming license slots unnecessarily.