Standardize code style #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used AppS.CodeTidy with the new tab setting set to 4 spaces.
Closed
Collaborator
Author
|
Note, this doesn't work cleanly for the CSP files server-side. Not going to worry about those for now. |
isc-tleavitt
commented
Nov 5, 2021
| self.process_http_backend() | ||
| else: | ||
| SimpleHTTPRequestHandler.do_GET(self) | ||
| elif self.is_git_request(): |
Collaborator
Author
There was a problem hiding this comment.
Kind of annoying what happened to the commented-out python equivalent here (especially since spacing matters in that context)... Maybe it's just time to kill these comments.
Contributor
There was a problem hiding this comment.
Do we still need this code? If so, we should go back and make an issue for it and embed the code in that. We can remove it from here then
Collaborator
Author
There was a problem hiding this comment.
I'd like to leave the remaining few bits as-is. No plans to implement but handy to know where we would if we decided to later.
Leaves in comments for things we didn't implement (particularly around serving as a git remote)
isc-svelury
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used AppS.CodeTidy with the new tab setting set to 4 spaces.