Skip to content

Storage definition changes export to Git repo #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isc-pbarton merged 1 commit into from
Dec 11, 2025
Merged

Storage definition changes export to Git repo #910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## Fixed
- Web UI workspace view labels changes as Merge Conflict if there are unmerged changes (#890)
- Web UI workspace view displays diff correctly for files with merge conflicts (#898)
- Storage definition changes in persistent classes are now correctly exported to the Git repository (#906)

## [2.14.0] - 2025-11-07

Expand Down
16 changes: 16 additions & 0 deletions cls/SourceControl/Git/Extension.cls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,6 +441,22 @@ Method OnAfterDelete(InternalName As %String) As %Status
quit $$$OK
}

/// This is called if you compile a class and the compilation updates the class storage.
/// It is called after the storage has been updated so you can determine how to deal with this
/// change in the class. The <var>Location</var> is the global reference to the class definition that was changed.
Method OnAfterStorage(InternalName As %String, Location As %String = "") As %Status
{
if (InternalName '= "") {
write !,"Item '"_InternalName_"' changed during compile so exporting new version."
set ..Modified(InternalName) = 1
set sc = ..OnAfterSave(InternalName)
if $$$ISERR(sc) {
do $System.OBJ.DisplayError(sc)
}
}
return $$$OK
}

/// Convert the internal name, e.g. TEST.MAC, to an external name that is used to export
/// the routine/class/csp item. This is often a filename to write the file out to.
Method ExternalName(InternalName As %String) As %String
Expand Down
Loading