Skip to content

Delay CPF merge activation until all config changes have been made during unmap and enable commands; also fix some mapped IPM issues#1054

Merged
isc-dchui merged 6 commits intomainfrom
fix-1001
Mar 9, 2026
Merged

Delay CPF merge activation until all config changes have been made during unmap and enable commands; also fix some mapped IPM issues#1054
isc-dchui merged 6 commits intomainfrom
fix-1001

Conversation

@isc-dchui
Copy link
Copy Markdown
Collaborator

Fixes #1001
Fixes #1052

This is what the intro message for a namespace with mapped IPM now looks like

==================================================================================================================
|| Welcome to the Package Manager Shell (ZPM). Version: 0.10.6-SNAPSHOT (mapped from namespace 'USER')          ||
|| Enter q/quit to exit the shell. Enter ?/help to view available commands                                      ||
|| Current registry https://pm.community.intersystems.com/                                                      ||
|| System Mode: <unset>                                                                                         ||
|| Mirror Status: NOTINIT                                                                                       ||
==================================================================================================================

Copy link
Copy Markdown
Collaborator

@isc-kiyer isc-kiyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isc-dchui just one comment but not blocking

Comment thread src/cls/IPM/Main.cls
set mirrorStatus = $system.Mirror.GetStatus()
set mirrorStatus = "Mirror Status: " _ mirrorStatus

if $$$ISERR(..GetIPMVersionInfo(.ipmVersion, .mappedFromNamespace)) {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this error status be written out instead of hiding it?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only errors that method will return are essentially that IPM isn't installed in or mapped to that namespace, so this is more presenting that in a clean way than hiding it.

@isc-dchui isc-dchui merged commit 589ce2b into main Mar 9, 2026
14 checks passed
@isc-dchui isc-dchui deleted the fix-1001 branch March 9, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants