Delay CPF merge activation until all config changes have been made during unmap and enable commands; also fix some mapped IPM issues#1054
Conversation
isc-kiyer
approved these changes
Mar 6, 2026
Collaborator
isc-kiyer
left a comment
There was a problem hiding this comment.
@isc-dchui just one comment but not blocking
| set mirrorStatus = $system.Mirror.GetStatus() | ||
| set mirrorStatus = "Mirror Status: " _ mirrorStatus | ||
|
|
||
| if $$$ISERR(..GetIPMVersionInfo(.ipmVersion, .mappedFromNamespace)) { |
Collaborator
There was a problem hiding this comment.
Should this error status be written out instead of hiding it?
Collaborator
Author
There was a problem hiding this comment.
The only errors that method will return are essentially that IPM isn't installed in or mapped to that namespace, so this is more presenting that in a clean way than hiding it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1001
Fixes #1052
This is what the intro message for a namespace with mapped IPM now looks like