Add ESLint

[isc-klu]

Fix #398

[isc-bsaviano]

Thanks for doing this KC! It's something I've been meaning to do but never got around to. You need to update .vscodeignore to ignore the new eslint config file. Have you experimented with removing any of the rules you defined?

[isc-klu]

You need to update .vscodeignore to ignore the new eslint config file.

Just did!.

Have you experimented with removing any of the rules you defined?

Do you mean the rules in eslint.config.mjs?

{
            "@typescript-eslint/no-explicit-any": "off",
            "@typescript-eslint/explicit-function-return-type": "off",
            "@typescript-eslint/no-unused-vars": "off",
            "@typescript-eslint/no-require-imports": "off",
            "@typescript-eslint/no-unused-expressions": "off",
}

No, I didn't experimented with them. They are copied from the config file for vscode-objectscript. I am happy to remove all of them and handle remaining lint issues.

[isc-bsaviano]

I'd be interested to see if adopting the default rules entirely radically changes anything.

[isc-klu]

Most rules are easy to remove, except for

• "...no-require-imports": "off", Some files have a lot of json-require (e.g., server/src/providers/completion.ts)
• "...no-explicit-any": "off",. We do want explicit any occationally (e.g., makeRESTRequest)

[isc-bsaviano]

I think we have to keep no-explicit-any. How does ESLint want us to import JSON files?

[isc-klu]

The change turns out to be trivial. See my previous commit.

[isc-bsaviano]

Nice work!