feature: add popular themes, and add syntax highlighting for Objectscript within XML files#2
Merged
davem-intersys merged 2 commits intointersystems:mainfrom Mar 10, 2026
Conversation
…ript within XML files Added the following themes: - solarized-dark - solarized-light - tokyonight-dark - tokyonight-day - tokyonight-light - tokyonight-moon Also, added the official XML grammar to this extension, and injected Implementation blocks with the objectscript playground grammar. This makes it so the objectscript gets highlighted.
Contributor
|
One note, does this make all XML have ObjectScript coloring? It's actually the 2nd line that makes InterSystems class-definition-as-XML disctinct: <?xml version="1.0" encoding="UTF-8"?>
<Export generator="IRIS" version="26"> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Added syntax highlighting for ObjectScript within XML files blocks. Additionally, added popular highlighting themes that users can choose from in Zed.
Testing
Tested that ObjectScript gets highlighted in XML files:
Tested the different themes:
Details
Added the following themes:
To enable syntax highlighting of ObjectScript within XML files, I added the official XML tree-sitter grammar to this extension, and added an injections.scm file that maps blocks to the objectscript playground grammar.