[uss_qualifier] Fix private repos locally #1027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-glu
approved these changes
May 21, 2025
monitoring/uss_qualifier/fileio.py
Outdated
| # Check if this is a request to a private GitHub repo | ||
| github_private_repos_key = "GITHUB_PRIVATE_REPOS" | ||
| if github_private_repos_key in os.environ: | ||
| if github_private_repos_key in os.environ and os.environ.get( |
Contributor
There was a problem hiding this comment.
os.environ.get is going to be None if the variable is not present, so the in part is redudent no?
Member
Author
There was a problem hiding this comment.
Agreed, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uss_qualifier has the capability to access private GitHub repos when provided with one or more access tokens to do so via the GITHUB_PRIVATE_REPOS environment variable. However, currently run_locally.sh produces an error when GITHUB_PRIVATE_REPOS is not provided because it is set to an empty value rather than being left unset. This PR addresses that problem in two ways: first, it doesn't set the environment variable in the docker container when it isn't provided/present, and second, empty GITHUB_PRIVATE_REPOS values are ignored.