Update the way key value parameters on auth adapter are parsed #1029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to support values that contain = as part of their string.
The committers listed above are authorized under a signed CLA. |
BenjaminPelletier
approved these changes
May 23, 2025
Member
BenjaminPelletier
left a comment
BenjaminPelletier
left a comment
There was a problem hiding this comment.
This is great -- thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support values that contain
=as part of their string. We ran into an issue where a client_secret value contained an=sign and it was not possible to get the test runner working with that secret. This change will make it so that the split occurs only on the first=and will ignore the ones in the value. It'll force a user to enter the params using key args but at least that path will work.