Skip to content

Conversation

@the-glu
Copy link
Contributor

@the-glu the-glu commented Jun 2, 2025

This PR Add yugabyte support:

  • Added specific yugabyte message to is_rechable function
  • Added specific yugaybtge message to runs_in_secure_mode function

@the-glu the-glu marked this pull request as draft June 2, 2025 13:20
@the-glu the-glu force-pushed the yugabyteaccess branch 2 times, most recently from 61f7f89 to 5f7459b Compare June 2, 2025 13:26
@the-glu the-glu marked this pull request as ready for review June 2, 2025 15:58
@the-glu
Copy link
Contributor Author

the-glu commented Jun 2, 2025

(tested with a CockroachDB and seems to be working as expected)

Copy link
Contributor

@mickmis mickmis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given its scale I think it's worth splitting the renaming from the yugabyte support for the scenario (and BTW specify which scenario is impacted).
Otherwise LGTM

@the-glu the-glu changed the title [uss_qualifier] Rename crdb to datastore and add yugabyte support [uss_qualifier] Add yugabyte support Jun 3, 2025
@the-glu
Copy link
Contributor Author

the-glu commented Jun 3, 2025

Rename moved out to #1037 (who should be merged first ^^')

Copy link
Contributor

@mickmis mickmis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 26bb62c
LGTM

@mickmis mickmis merged commit c44d57c into interuss:main Jun 3, 2025
21 checks passed
@mickmis mickmis deleted the yugabyteaccess branch June 3, 2025 13:40
github-actions bot added a commit to openutm-labs/monitoring that referenced this pull request Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants