[uss_qualifier] oir implicit sub: update test case cleanups, request implicit subscription to replace explicit subscription #1036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
Shastick
force-pushed
the
oir-implicit-expand-7
branch
from
2a85f67 to
2b92c7e
Compare
Shastick
force-pushed
the
oir-implicit-expand-7
branch
from
2b92c7e to
a515c6e
Compare
monitoring/uss_qualifier/scenarios/astm/utm/dss/oir_implicit_sub_handling.md
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/utm/dss/oir_implicit_sub_handling.md
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/utm/dss/oir_implicit_sub_handling.md
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/utm/dss/oir_implicit_sub_handling.md
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Cleanup test steps now only reference |
Shastick
force-pushed
the
oir-implicit-expand-7
branch
from
a515c6e to
23e8b65
Compare
mickmis
approved these changes
Jun 5, 2025
Contributor
mickmis
left a comment
mickmis
left a comment
There was a problem hiding this comment.
It also includes:
- some reordering: rather than "resetting" things before a test case starts, we have each test case clean up after itself.
- new implementations for some fragments
Please reflect it in PR title (or split away).
Otherwise LGTM modulo minor comments.
monitoring/uss_qualifier/scenarios/astm/utm/dss/oir_implicit_sub_handling.md
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/utm/dss/fragments/sub/crud/__init__.py
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/utm/dss/oir_implicit_sub_handling.py
Outdated
Show resolved
Hide resolved
monitoring/uss_qualifier/scenarios/astm/utm/dss/oir_implicit_sub_handling.py
Outdated
Show resolved
Hide resolved
Shastick
changed the title
Shastick
force-pushed
the
oir-implicit-expand-7
branch
2 times, most recently
from
352ca68 to
d4e98bd
Compare
Shastick
force-pushed
the
oir-implicit-expand-7
branch
from
d4e98bd to
724e582
Compare
Contributor
Author
|
@mickmis comments are addressed (and some other small cleanups), PR should be ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers case (7) from interuss/dss#1088
It also includes: