[uss_qualifier/netrid/common_dictionary_evaluator] Evaluate specific types of UAS ID for DP and SP #1056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickmis
force-pushed
the
857/eval_uas_id_types
branch
from
119d09f to
2715400
Compare
mickmis
force-pushed
the
857/eval_uas_id_types
branch
from
2715400 to
6d59aad
Compare
BenjaminPelletier
approved these changes
Jul 12, 2025
… UAS ID evaluation
…types of UAS ID for DP and SP
mickmis
force-pushed
the
857/eval_uas_id_types
branch
from
6d59aad to
3909dab
Compare
Contributor
Author
|
@BenjaminPelletier in your comments on #1055 I've identified 2 that were still relevant in this PR, which I fixed. LMK if my assessment was wrong and I will follow-up with a fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on top of #1055 please only review 6d59aad
This should fix #857
This PR changes type-specific UAS ID evaluation functions so that they support evaluation of both DP and SP observed values.
For the DP, it does so by comparing the observed value with the injected value, and proceeding only if they are equal. This effectively skip the check of the requirements when it cannot be determined whether the UAS ID is valid or not, and it passes the check whenever the values match.