Skip to content

[uss_qualifier] OIRValidator: implement missing documented checks #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025
Merged

[uss_qualifier] OIRValidator: implement missing documented checks #1069

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion monitoring/uss_qualifier/scenarios/astm/utm/dss/validators/oir_validator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,17 @@ def _validate_oir(
t_dss=t_dss,
)

with self._scenario.check(
"Returned operational intent reference has a version", self._pid
) as check:
if "version" not in dss_oir or dss_oir.version is None:
self._fail_sub_check(
check,
summary="Returned OIR has no version",
details="The operational intent reference returned by the DSS has no version when it should have one",
t_dss=t_dss,
)

# If the previous version is not None, we are dealing with a mutation:
if previous_version is not None:
with self._scenario.check(
Expand Down Expand Up @@ -269,8 +280,18 @@ def _validate_oir(
t_dss=t_dss,
)

with self._scenario.check(
"Returned operational intent reference state is correct", self._pid
) as check:
if dss_oir.state != self._oir_params.state:
self._fail_sub_check(
check,
summary="Returned OIR state is incorrect",
details=f"Expected: {self._oir_params.state}, got {dss_oir.state}",
t_dss=t_dss,
)

# TODO add check for:
# - state
# - subscription ID of the OIR (based on passed parameters, if these were set)

def _validate_put_oir_response_schema(
Expand Down
Loading