[uss_qualifier] subscription scenarios: remove redundant documented checks #1073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shastick
force-pushed
the
subs-fix-doc-or-checks
branch
from
a218816 to
e22b77e
Compare
Shastick
force-pushed
the
subs-fix-doc-or-checks
branch
from
e22b77e to
4276c35
Compare
mickmis
approved these changes
Jul 22, 2025
|
|
||
| If it does not, the DSS is failing to implement **[astm.f3548.v21.DSS0005,5](../../../../requirements/astm/f3548/v21.md)**. | ||
|
|
||
| #### 🛑 Subscription can be deleted check |
Contributor
There was a problem hiding this comment.
This looks correct since the CI does not fail with the removal, but this is not documented in the PR description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove redundant checks from UTM subscription related scenarios.
For
subscription_synchronizationthis involves adding a fragment and reorganizing things so that a fragment that does not import theupdate_queryfragment (that defines theSubscription can be mutatedcheck, which is redundant in the context of theMutate subscription on secondariestest step, because we already have an equivalent check under a different name).Subscription returned by a secondary DSS is valid and correctis removed because it is redundant withMutate subscription response content is correctthat is already documented and checked via theupdate_validation.mdfragmentProgress on #975