[mock_uss] Fix clustering #1161
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The randomize function of the mock_uss's clustering is wrong and can generate clusters outside the list of points.
Keeping it in one axes, if min = 0, max = 4 and points = [1, 3], this mean
Should we chose
-3as valuex_min = -3 x_max = 1Meaning our clustering window will have one point outside of the cluster.
This PR fixes it with another calculation with explanations, see the code.
This PR also fix
extendthat was wrongly usedselfinstead of new cluster, and do a copy of points to avoid having the same list between cluster's copies.