-
Notifications
You must be signed in to change notification settings - Fork 28
Bump sigstore/cosign-installer from 3.10.0 to 4.0.0 #1243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump sigstore/cosign-installer from 3.10.0 to 4.0.0 #1243
Conversation
|
@mickmis could you take a look to make sure this major-version upgrade won't cause any problems? I hesitate to make a major version upgrade automatically, especially since I don't think we have strong automated test coverage of the potential consequences of the upgrade. |
I've not come around to test this. This upgrade indeed deserves to be tested manually: this upgrades the version of Cosign from v2 to v3. |
Bumps [sigstore/cosign-installer](https://github.com/sigstore/cosign-installer) from 3.10.0 to 4.0.0. - [Release notes](https://github.com/sigstore/cosign-installer/releases) - [Commits](sigstore/cosign-installer@d7543c9...faadad0) --- updated-dependencies: - dependency-name: sigstore/cosign-installer dependency-version: 4.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
2d5830e to
4c780ac
Compare
|
It looks like the upgrade of cosign from v2 to v3 is not exactly smooth. It notably seems to be using a new format to store signatures. And there is some retrocompatbility using a specific flag. But apparently not all subcommands support that yet somehow? |
4c780ac to
730d917
Compare
730d917 to
bfedba6
Compare
mickmis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bfedba6 pins the cosign version to v2.6.1 (using github action cosign-installer v4.0.0) and confirms the image is signed correctly and can be verified. I will revert the changes made for testing and merge this PR.
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mickaël Misbach <mickael@misba.ch> beb8c9a
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mickaël Misbach <mickael@misba.ch> beb8c9a
Bumps sigstore/cosign-installer from 3.10.0 to 4.0.0.
Release notes
Sourced from sigstore/cosign-installer's releases.
Commits
faadad0add support for cosign v3 releases (#201)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)