[uss_qualifier/reports] Add KML visualization of RID test queries to sequence view artifact#1382
Conversation
Shouldn't we use ignore statements for that? I would say that baseline is for the baseline, created at the start, and ignore is when we processed it and there are no others solutions. |
I tried some solution, it seems that "cheating" is not possible on Solution is either to switch to a generic callable ( |
Fair enough; reverted baseline change.
Yeah, if these functions really fully implemented Protocol that would be true, but the idea here is to allow for a subset of arguments since only one thing will be calling them and it will apply special logic depending on which arguments are specified. That's hard to type-annotate in Python :/
Yeah, that seems substantially less informative; I suppose we'll just take the |
To support debugging a challenging remote ID test report, I added a mechanism to render two new types of queries (RID injection "create test" and F3411-22a "search flights") to those which generate KML content for the sequence view artifact.
A few small issues noticed during this work are also cleaned up:
basedpyright does not like the clever(?) feature of the QueryKMLRenderer Protocol which allows one or more of the specified arguments to be omitted with defined behavior when that happens (see query_kml_renderer decorator documentation), so two new items are added to the baseline.json backlog. I also added a Make target to make additions/exceptions like this easier to manage. Suggestions for ways to avoid these findings entirely are welcome (e.g., more accurate typing on QueryKMLRenderer or elsewhere).