Skip to content

[netrid] Fix misbehaviour tests by not using too large area for Unauthenticated / Incorrectly authenticated requests#1396

Merged
BenjaminPelletier merged 1 commit intointeruss:mainfrom
Orbitalize:fix_misbehaviour
Mar 18, 2026
Merged

[netrid] Fix misbehaviour tests by not using too large area for Unauthenticated / Incorrectly authenticated requests#1396
BenjaminPelletier merged 1 commit intointeruss:mainfrom
Orbitalize:fix_misbehaviour

Conversation

@the-glu
Copy link
Contributor

@the-glu the-glu commented Mar 18, 2026

This PR follow #1388

It does fix the strange behavior of 'misbehaviour' tests, that tried first with an invalid area to retrive flights to be tested for Unauthenticated / Incorrectly authenticated requests.

Notice invalid area queries are still tested in the 'Invalid search area' test.

Before:

image

After:

image

…henticated / Incorrectly authenticated requests
Copy link
Member

@BenjaminPelletier BenjaminPelletier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hypothetically, the unauthenticated coverage could extend to queries expected to elicit errors like 413 for too large of a diagonal when authenticated. For instance, a USS could have a bug that properly 401s in most cases, but 413s even when unauthenticated. In that case, these queries might have served as the authenticated side of the unauthenticated-with-too-large-diagonal case. But, we don't actually perform the unauthenticated-with-too-large-diagonal case so we definitely shouldn't perform the authenticated side. And, I don't know that we would want to spend the necessary queries to achieve that particular coverage -- automated testing coverage is far, far cheaper than manual testing, but it's not free (for the users running it, in addition to dev+maintenance time) so we do need to keep an eye on our value/cost. So, I think this PR is appropriate :)

@BenjaminPelletier BenjaminPelletier merged commit 74a93e0 into interuss:main Mar 18, 2026
22 checks passed
github-actions bot added a commit that referenced this pull request Mar 18, 2026
…area for Unauthenticated / Incorrectly authenticated requests (#1396) 74a93e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants