Skip to content

Remove leftover of 'successes' not converted to 'passes' #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mickmis merged 1 commit into from
Apr 23, 2026
+4 −4
Merged

Remove leftover of 'successes' not converted to 'passes' #1435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion monitoring/uss_qualifier/reports/templates/sequence_view/overview.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ <h2>Scenarios executed</h2>
<td class="fail_result"><span class="sticky_cell_value">&#x274C;</span></td>
{% elif row.scenario_node.scenario.participants[participant_id].has_infos %}
<td class="info_result"><span class="sticky_cell_value">&#8505;&#65039;</span></td>
{% elif row.scenario_node.scenario.participants[participant_id].has_successes %}
{% elif row.scenario_node.scenario.participants[participant_id].has_passes %}
<td class="pass_result"><span class="sticky_cell_value">&#x2705;</span></td>
{% elif row.scenario_node.scenario.participants[participant_id].has_queries %}
<td><span class="sticky_cell_value">&#x1F310;</span></td>
Expand Down
4 changes: 2 additions & 2 deletions .../uss_qualifier/reports/templates/tested_requirements/participant_tested_requirements.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,8 @@ <h2>Tested requirements</h2>
{% else %}
{{ check.name }}
{% endif %}
{% if check.successes + check.failures > 1 %}
({{ check.successes + check.failures }}x)
{% if check.passes + check.failures > 1 %}
({{ check.passes + check.failures }}x)
{% endif %}
</td>
</tr>
Expand Down
2 changes: 1 addition & 1 deletion monitoring/uss_qualifier/scenarios/documentation/requirements.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def _add_check(
for participant_id in participants:
if participant_id not in requirement.participant_performance:
requirement.participant_performance[participant_id] = (
ParticipantRequirementPerformance(successes=[], failures=[])
ParticipantRequirementPerformance(passes=[], failures=[])
)
performance = requirement.participant_performance[participant_id]
if isinstance(check, PassedCheck):
Expand Down
Loading