[uss_qualifier] MockUssClient and test steps with FlightPlannerClient#347
Merged
BenjaminPelletier merged 19 commits intointeruss:mainfrom Nov 20, 2023
Merged
Conversation
Contributor
punamverma
commented
Nov 16, 2023
punamverma
commented
- Added V1FlightPlannerClient to MockUssClient, as we ll use MockUssClient for planning flights in test scenarios.
- Added tests steps that use V1FlightPlannerClient for planning flights.
…n flight using FlightPlannerClient
punamverma
changed the title
Contributor
Author
|
@BenjaminPelletier PR is ready for review. Thanks |
Member
BenjaminPelletier
left a comment
BenjaminPelletier
left a comment
There was a problem hiding this comment.
In addition to the comments below, we want to make sure the code works. Since these steps are being developed for a scenario that is already documented and already has an empty implementation, it should only take a few lines to call the new steps (plan_flight and cleanup_flights_fp_client) from that scenario so that nearly all of the code in the PR is actually exercised by the CI. We don't need to implement all steps of that scenario in this PR, but calling each of these two new steps once would provide nearly full test coverage of the changes in this PR.
Co-authored-by: Benjamin Pelletier <BenjaminPelletier@users.noreply.github.com>
Contributor
Author
|
@BenjaminPelletier Fixed the review comments. Added some steps in scenario to use the new test_steps methods. Could you please check. Thanks. |
Contributor
Author
|
@BenjaminPelletier @barroco @mickmis PR is ready for your review. Thanks |
Co-authored-by: Benjamin Pelletier <BenjaminPelletier@users.noreply.github.com>
Contributor
Author
|
@BenjaminPelletier @barroco @mickmis Fixed PR comments. Ready for another review. |
BenjaminPelletier
approved these changes
Nov 20, 2023
github-actions Bot
added a commit
that referenced
this pull request
Nov 20, 2023
…#347) * Added V1FlightPlannerClient to MockUssClient; added test steps to plan flight using FlightPlannerClient * Removing unwanted port mapping * Removing unwanted import * Update monitoring/uss_qualifier/resources/interuss/mock_uss/client.py Co-authored-by: Benjamin Pelletier <BenjaminPelletier@users.noreply.github.com> * Fixing per PR review comments * Remove an unwanted import * Adding missing code * Removing code causing failure * Fix bug * Fix format * Fix bug * Update monitoring/uss_qualifier/scenarios/flight_planning/test_steps.py Co-authored-by: Benjamin Pelletier <BenjaminPelletier@users.noreply.github.com> * Fixing PR review comments * Removing if condition not required * Fix per PR review * Nit fix per review --------- Co-authored-by: Benjamin Pelletier <BenjaminPelletier@users.noreply.github.com> 58fdbcb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.